pseudopatterns polluting base patterns#744
Merged
bmuenzenmeyer merged 3 commits intodevfrom Nov 10, 2017
Merged
Conversation
bmuenzenmeyer
changed the title
bmuenzenmeyer
changed the title
1 similar comment
Member
Author
|
(code coverage decrease is likely due to deleting duplicate code, not the fix itself) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #711
Summary of changes:
pseudopattern_hunter is performing a dangerous lodash merge against the base pattern data
resulting in the mutation of the
currentPattern.jsonFileData object.Luckily, we get around this elsewhere by using
jsonCopyon the merged objects.I also verified this now using starterkit-mustache-demo.
FIX NOT APPLIED, DASHBOARD
(wrong data)
FIX NOT APPLIED, DASHBOARD ~ HACKED
(wrong data)
FIX APPLIED, DASHBOARD
(correct default data)
FIX APPLIED, DASHBOARD ~ HACKED
(correct override data)